projectmoon
/
tenebrous-dicebot
1
0
Fork 1
Code Issues 12 Pull Requests 1 Projects Releases 10 Wiki Activity

Log if there are failures when executing multiple commands #25

New Issue
Closed
opened 2020-10-22 20:33:47 +00:00 by projectmoon · 3 comments
projectmoon commented 2020-10-22 20:33:47 +00:00
Owner
Copy Link

Right now it just says how many it executed.

This is actually more involved than it seems, because it requires some re-architecting of the command execution code.

  • Convert command execution to use Results.
  • Count how many commands errored out in a multi-command scenario.
  • Print failed commands and the corresponding error messages.
Right now it just says how many it executed. This is actually more involved than it seems, because it requires some re-architecting of the command execution code. - [X] Convert command execution to use Results. - [X] Count how many commands errored out in a multi-command scenario. - [X] Print failed commands and the corresponding error messages.
projectmoon self-assigned this 2021-01-30 17:04:17 +00:00
projectmoon commented 2021-01-30 17:04:34 +00:00
Author
Owner
Copy Link

PR #51 gives us results for commands.

PR #51 gives us results for commands.
projectmoon commented 2021-01-31 14:13:23 +00:00
Author
Owner
Copy Link

PR #52 gives us the rest, in addition to a bunch of other benefits (less code, easier response handling).

PR #52 gives us the rest, in addition to a bunch of other benefits (less code, easier response handling).
projectmoon commented 2021-01-31 14:37:20 +00:00
Author
Owner
Copy Link

Closed in #52.

Closed in #52.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
cargo-update
variables-help
webui-attempt-2
web-api
set-room-command
state-revamp
sqlite
rust-1.51
cthulhu-advancement-variables
really-log-multi-command-failures
v0.13.2
v0.13.1
v0.13.0
v0.12.0
v0.11.0
v0.10.0
v0.9.0
v0.8.0
v0.7.0
v0.6.0
v0.5.2
v0.5.1
0.5.1
0.2.0
0.5.0
0.4.0
0.3.0
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
projectmoon
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: projectmoon/tenebrous-dicebot#25
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?