Better formatting of re-rolled dice #4

New Issue

Open

opened 2020-09-25 22:09:28 +00:00 by projectmoon · 0 comments

projectmoon commented

2020-09-25 22:09:28 +00:00

Owner

It can sometimes be be difficult to tell how the dicebot is re-rolling dice in the Chronicles of Darkness dicepool system. It would be useful to see something like 2 => 10 => 10, 8, 4 to indicate a reroll. There are two parts to this: changing code to support the possibility, and then making the formatting nice.

Instead of having dice roll functions return a Vec<u32> and tacking that on to a full set of rolls, a dice pool roll should be represented by a Vec<SingleRoll>, where SingleRoll has one or more actual rolls in it.
The SingleRoll trait can implement Display to provide the better formatting.
Code for calculating successes etc needs to sum up the total successes of each single roll to be accurate.

It can sometimes be be difficult to tell how the dicebot is re-rolling dice in the Chronicles of Darkness dicepool system. It would be useful to see something like `2 => 10 => 10, 8, 4` to indicate a reroll. There are two parts to this: changing code to support the possibility, and then making the formatting nice. * Instead of having dice roll functions return a `Vec<u32>` and tacking that on to a full set of rolls, a dice pool roll should be represented by a `Vec<SingleRoll>`, where `SingleRoll` has one or more actual rolls in it. * The `SingleRoll` trait can implement `Display` to provide the better formatting. * Code for calculating successes etc needs to sum up the total successes of each single roll to be accurate.