Refactor keep-drop parsing into function, better error handling. #93

Merged

projectmoon merged 2 commits from keep-drop-refactoring into master

2021-09-30 21:16:04 +00:00

projectmoon commented

2021-09-26 23:10:01 +00:00

Owner

This allows us to express "this behavior is correct, and all others are not" instead of using a "fall back to secondary functionality" approach.

This commit refactors the keep-drop parsing into two separate functions: one for extracting keep-drop text, and one for actually doing something with the extracted values. An intermediate enum is introduced to contain extracted text, instead of relying on Ok/Err values directly for figuring out what to do with the values. This allows us to express "this behavior is correct, and all others are not" instead of using a "fall back to secondary functionality" approach.

projectmoon added 1 commit 2021-09-26 23:10:04 +00:00

continuous-integration/drone/push Build is passing Details

continuous-integration/drone/pr Build is passing Details

0cb48bea07 Refactor keep-drop parsing into function, better error handling.

This commit refactors the keep-drop parsing into two separate
functions: one for extracting keep-drop text, and one for actually
doing something with the extracted values. An intermediate enum is
introduced to contain extracted text, instead of relying on Ok/Err
values directly for figuring out what to do with the values.

This allows us to express "this behavior is correct, and all others
are not" instead of using a "fall back to secondary functionality"
approach.

projectmoon added 1 commit 2021-09-26 23:19:58 +00:00

continuous-integration/drone/push Build is passing Details

continuous-integration/drone/pr Build is passing Details

ef5b4cb69b Potentially valid, not always valid.