Room State Management #44

projectmoon · 2020-11-09T21:25:21Z

projectmoon commented

2020-11-09 21:25:21 +00:00

Design Document: https://git.agnos.is/projectmoon/matrix-dicebot/wiki/Feature%3A-Room-State-Management

When the design document is fulfilled and all issues checked off, then this can be merged.

Design Document: https://git.agnos.is/projectmoon/matrix-dicebot/wiki/Feature%3A-Room-State-Management Issue: https://git.agnos.is/projectmoon/matrix-dicebot/issues/20 When the design document is fulfilled and all issues checked off, then this can be merged.

projectmoon added 8 commits 2020-11-09 21:25:24 +00:00

8e2f34819e Half implemented room state management foundations.

51ba3e3f42 Record user join/leaves in rooms. Move event emitter to its own file.

b5c78bcee5 Remove userandroom struct from rooms db

d7aaed9e00 Implement room clearing, log to info for member updates.

fb24090952 Keep seen events in database, don't process already-seen events.

Adds a new function `should_process` to rooms impl that determines if
calling could should proceed with processing an event ID. Event IDs
are recorded (along with room ID) as a key pointing to the
system-local timestamp of when the event was received. If the key was
not originally present, we instruct calling code to process the event.

Events are also asychronously recorded by timestamp using a sled event
watcher that listens to inserts in the main tree (described above).
This secondary tree will allow easy cleanup of old events in the
future.

74d0b88e80 Add should process check to room member event

9349dd5f00 Add event processing check to received messages.

Also rename the existing `should_process` function to be more clear,
given presence of another similarly named function:
should_process_message.

continuous-integration/drone/push Build is passing Details

continuous-integration/drone/pr Build is passing Details

0939feee84 Placeholder to record all user info when joining room

projectmoon changed title from ~~Room State Management~~ to WIP:Room State Management

2020-11-09 21:25:34 +00:00

projectmoon commented

2020-11-09 21:43:04 +00:00

As of this writing, there are two missing pieces of functionality before merging:

Adding all users in the room to the database upon joining a room.
Recording room-level information (ID, name, etc) when joining a room.

As of this writing, there are two missing pieces of functionality before merging: * Adding all users in the room to the database upon joining a room. * Recording room-level information (ID, name, etc) when joining a room.

projectmoon reviewed 2020-11-09 21:50:22 +00:00

src/db/rooms.rs

					
				@ -0,0 +61,4 @@

				/// HashSets as its values. Atomicity is partially handled. If the

				/// Tree is a transactional tree, operations will be atomic.

				/// Otherwise, there is a potential non-atomic step.

				mod hashset_tree {

projectmoon commented

2020-11-09 21:49:36 +00:00

Perhaps move this and TxableTree into a common part of the database code. Maybe also convert it to a trait. The atomicity issues with Tree instances also should be addressed. Use fetch_and_update when it's a regular Tree, and the existing code if it's a TransactionalTree (since the atomicity is controlled by the transaction).

Perhaps move this and `TxableTree` into a common part of the database code. Maybe also convert it to a trait. The atomicity issues with `Tree` instances also should be addressed. Use `fetch_and_update` when it's a regular Tree, and the existing code if it's a `TransactionalTree` (since the atomicity is controlled by the transaction).

projectmoon commented

2020-11-10 20:24:24 +00:00

Deferring to a future changeset.

projectmoon marked this conversation as resolved

src/db/rooms.rs Outdated

					
				@ -0,0 +115,4 @@

				}

				/// Functions that specifically relate to the "timestamp index" tree,

				/// which is stored on the Room sinstance as a tree called