projectmoon
/
tenebrous-dicebot
1
0
Fork 1
Code Issues 12 Pull Requests 1 Projects Releases 10 Wiki Activity

Record room information (ID, name) in the database #48

Manually merged
projectmoon merged 10 commits from record-room-info into master 2020-11-30 20:16:01 +00:00
Conversation 1 Commits 10 Files Changed 14 +182 -37
projectmoon commented 2020-11-29 21:40:55 +00:00
Owner
Copy Link

Second major part of room state management: storing of room information in the database. This records room and their users by IDs when joining the room, and also if a resync command is executed. Some further work is needed before merging:

  • Do not dive into the event handlers module to call the record function from a command. Create a new shared logic layer instead.
  • Somehow break down the event handler method further?
  • Resync all rooms on startup (probably in a separate PR).
Second major part of room state management: storing of room information in the database. This records room and their users by IDs when joining the room, and also if a resync command is executed. Some further work is needed before merging: - [X] Do not dive into the event handlers module to call the record function from a command. Create a new shared logic layer instead. - [ ] Somehow break down the event handler method further? - [ ] Resync all rooms on startup (probably in a separate PR).
projectmoon added 9 commits 2020-11-29 21:40:58 +00:00
continuous-integration/drone/push Build is passing Details
224f8cd0f1 Functions for storing RoomInfo in db. Refactor bot joins room event. 
Add get/insert functions for RoomInfo in the rooms db.

Move 'bot joins room' code to single method, so we can also record a
RoomInfo struct into the database.
continuous-integration/drone/push Build is passing Details
91cfc52e5b Change record_users_in_room to record_room_information.
continuous-integration/drone/push Build is passing Details
c8c38ac1d4 Avoid nested map when retrieving room info from db.
continuous-integration/drone/push Build is passing Details
7e1abab66d Resync command now uses record_room_information.
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
a65084e04a Unit test for updating room info data.
projectmoon added 1 commit 2020-11-30 19:55:35 +00:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is failing Details
e177da9c25 Centralize record_room_information function.
projectmoon commented 2020-11-30 20:14:54 +00:00
Author
Owner
Copy Link

Fixes #29.

Fixes #29.
projectmoon manually merged commit 59fc281a0c into master 2020-11-30 20:16:01 +00:00
projectmoon deleted branch record-room-info 2020-11-30 20:16:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: projectmoon/tenebrous-dicebot#48
No description provided.
Delete Branch "record-room-info"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?