projectmoon
/
tenebrous-dicebot
1
0
Fork 1
Code Issues 12 Pull Requests 1 Projects Releases 10 Wiki Activity

Switch order of modifier parsing for CofD and Cthulhu #94

Merged
projectmoon merged 2 commits from modifiers-after-amount into master 2021-11-06 21:23:53 +00:00
Conversation 0 Commits 2 Files Changed 4 +140 -117
projectmoon commented 2021-11-05 20:54:08 +00:00
Owner
Copy Link

Changes the parsing logic to accept modifiers for CofD/Cthulhu rolls after the main expression, rather than before separated by a colon. Easier to type.

Also fixes a minor bug where any non-modifier text after the number in a Cthulhu roll would be interpreted as a normal roll instead of an error.

Changes the parsing logic to accept modifiers for CofD/Cthulhu rolls after the main expression, rather than before separated by a colon. Easier to type. Also fixes a minor bug where any non-modifier text after the number in a Cthulhu roll would be interpreted as a normal roll instead of an error.
projectmoon added 2 commits 2021-11-05 20:54:11 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
9b3d688cef Change modifier order in Cthulhu
projectmoon merged commit c514b85510 into master 2021-11-06 21:23:53 +00:00
projectmoon deleted branch modifiers-after-amount 2021-11-06 21:24:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: projectmoon/tenebrous-dicebot#94
No description provided.
Delete Branch "modifiers-after-amount"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?