projectmoon
/
tenebrous-dicebot
1
0
Fork 1
Code Issues 12 Pull Requests 1 Projects Releases 10 Wiki Activity

Convert command execution to use results #51

Manually merged
projectmoon merged 1 commits from log-failed-multi-commands into master 2021-01-30 17:03:07 +00:00
Conversation 0 Commits 1 Files Changed 9 +145 -130
projectmoon commented 2021-01-30 14:21:51 +00:00
Owner
Copy Link

This PR changes the command pipeline to use Result semantics, which has a lot of benefits for code quality. The main point of the PR, though, is to allow for better output of multi-command execution where only some commands fail.

This PR changes the command pipeline to use Result semantics, which has a lot of benefits for code quality. The main point of the PR, though, is to allow for better output of multi-command execution where only some commands fail.
projectmoon added 1 commit 2021-01-30 14:21:54 +00:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
bf1e2a248f Convert command execution to use results.
projectmoon force-pushed log-failed-multi-commands from bf1e2a248f to 16eb87e50f 2021-01-30 14:28:29 +00:00 Compare
projectmoon manually merged commit 16eb87e50f into master 2021-01-30 17:03:07 +00:00
projectmoon deleted branch log-failed-multi-commands 2021-01-30 17:03:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: projectmoon/tenebrous-dicebot#51
No description provided.
Delete Branch "log-failed-multi-commands"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?